prevent terminating already-terminated process on WSL #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents `proc.terminate()` from throwing an exception when the process has already terminated. Potential fix for Zulko#765
|
Just tried on Ubuntu 18.04 Python 3.6.5 on my WSL environment and still getting the |
|
Can you share the code that is producing the error? What is the full stack trace? |
|
Figured it out. It seems like this fix is just for the video, implemented the same fix for the audio under the pull request: #864 |
5 tasks
|
Hi, thanks for your contribution. Is this a duplicate of #864 ? |
|
Fixed by #927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents
proc.terminate()from throwing an exception when the process has already terminated.Potential fix for #765